Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add latest commit used used to build in /api/peers/version #340

Closed
ghost opened this issue Dec 6, 2016 · 6 comments · Fixed by #371
Closed

Add latest commit used used to build in /api/peers/version #340

ghost opened this issue Dec 6, 2016 · 6 comments · Fixed by #371
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Dec 6, 2016

{"success":true,"version":"0.5.0","build":"v06:02:05 30/11/2016\n"}
/api/peers/version

It's needed for Lisk Network Stats to use when there is not build info or just along with date to get exact version.

@ghost ghost changed the title Add latest commit used used to build in Add latest commit used used to build in /api/peers/version Dec 6, 2016
@Isabello
Copy link
Contributor

Isabello commented Dec 6, 2016 via email

@ghost
Copy link
Author

ghost commented Dec 6, 2016

But there is no build informations specified when someone compile directly from repository and then statistics website is incomplete. This is relatively easy to implement.

@Isabello
Copy link
Contributor

Isabello commented Dec 6, 2016

Can you give me an example or a pull request to implement this feature? I don't see it being easy unless we add functionality to check git log as part of core.

@ghost
Copy link
Author

ghost commented Dec 6, 2016

It can be done during building, stored in config then easily accessible by node. I think this is simplest approach.

@Isabello
Copy link
Contributor

Isabello commented Dec 6, 2016

we dont build the client if we run from source. so the build file is never populated on a source configured node.

@ghost
Copy link
Author

ghost commented Dec 6, 2016

@MaciejBaj MaciejBaj self-assigned this Jan 4, 2017
MaciejBaj added a commit to MaciejBaj/lisk that referenced this issue Jan 4, 2017
After call to /api/peers/version return build info if lisk was installed from binaries or last commit if installed using source.

closes LiskArchive#340
@karmacoma karmacoma added this to the Core Sprint 01 milestone Jan 19, 2017
MaciejBaj added a commit to MaciejBaj/lisk that referenced this issue Jan 25, 2017
After call to /api/peers/version return build info if lisk was installed from binaries or last commit if installed using source.

closes LiskArchive#340
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants