This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 457
Add latest commit used used to build in /api/peers/version #340
Comments
There is only one release/build per revision. This is a waste to implement
and creates no benefit.
…On Tue, Dec 6, 2016 at 2:24 PM, Unhandled Exception < ***@***.***> wrote:
{"success":true,"version":"0.5.0","build":"v06:02:05 30/11/2016\n"}
/api/peers/version
It's needed for Lisk Network Stats
<https://github.com/karek314/lisk-network-reporter> to use when there is
not build info or just along with date to get exact version.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#340>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/APzFsCc3znLrLppIQ-yjo85VFERgTGJmks5rFcRlgaJpZM4LF109>
.
|
But there is no build informations specified when someone compile directly from repository and then statistics website is incomplete. This is relatively easy to implement. |
Can you give me an example or a pull request to implement this feature? I don't see it being easy unless we add functionality to check git log as part of core. |
It can be done during building, stored in config then easily accessible by node. I think this is simplest approach. |
we dont build the client if we run from source. so the build file is never populated on a source configured node. |
There are few other ways |
MaciejBaj
added a commit
to MaciejBaj/lisk
that referenced
this issue
Jan 4, 2017
After call to /api/peers/version return build info if lisk was installed from binaries or last commit if installed using source. closes LiskArchive#340
MaciejBaj
added a commit
to MaciejBaj/lisk
that referenced
this issue
Jan 25, 2017
After call to /api/peers/version return build info if lisk was installed from binaries or last commit if installed using source. closes LiskArchive#340
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It's needed for Lisk Network Stats to use when there is not build info or just along with date to get exact version.
The text was updated successfully, but these errors were encountered: