This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add latest commit info reachable through API #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After call to /api/peers/version return build info if lisk was installed from binaries or last commit if installed using source. closes LiskArchive#340
4miners
reviewed
Jan 4, 2017
| return setImmediate(cb, null, response); | ||
| } | ||
| catch (err) { | ||
| return setImmediate(cb, 'Git is not installed or not a git repository'); |
There was a problem hiding this comment.
So when there is no build and no git / repository - that endpoint will fail entirely and not return version? Imo that endpoint should never fail.
There was a problem hiding this comment.
Right, I changed it, so always build and commit info are returned if exists.
Fix case when no response is returned when lisk was installed neither from source nor binaries. fixes LiskArchive#371
karmacoma
approved these changes
Jan 5, 2017
MaciejBaj
added a commit
to MaciejBaj/lisk
that referenced
this pull request
Jan 25, 2017
Fix case when no response is returned when lisk was installed neither from source nor binaries. fixes LiskArchive#371
karmacoma
added
ready
and removed
type: test
standards
type: improvement
type: bug
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After call to /api/peers/version return build info if lisk was installed from binaries or last commit if installed using source.
closes #340