You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
### What was the problem?
This PR resolves#7567
### How was it solved?
Update engine and application based on
LiskArchive/lips#177
- Update validators module to store consensus information before passing
to ABI
- Move `getSlotTime`, `getSlotNumber` and `getGeneratorAtTimestamp` to
BFT method, and update its usages
- Update DPoS module to use validators module instead of replying
directly through context
- Update block header to add impliesMaxPrevote
- Update consensus to verify impliesMaxPrevote
- Update generator to add impliesMaxPrevote
- Add genesis block validation for impliesMaxPrevote
- Update dpos module unlock to use aggregateCommit.height for checking
certified
### How was it tested?
- Add more test case impliesMaxPrevote method
- Update the usage and test for the consensus params
### Additional Information
Currently genesis timestamp is not stored in BFT module
LiskArchive/lips#177 (comment)
This PR resolves#7567
Update engine and application based on
LiskArchive/lips#177
- Update validators module to store consensus information before passing
to ABI
- Move `getSlotTime`, `getSlotNumber` and `getGeneratorAtTimestamp` to
BFT method, and update its usages
- Update DPoS module to use validators module instead of replying
directly through context
- Update block header to add impliesMaxPrevote
- Update consensus to verify impliesMaxPrevote
- Update generator to add impliesMaxPrevote
- Add genesis block validation for impliesMaxPrevote
- Update dpos module unlock to use aggregateCommit.height for checking
certified
- Add more test case impliesMaxPrevote method
- Update the usage and test for the consensus params
Currently genesis timestamp is not stored in BFT module
LiskArchive/lips#177 (comment)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
ValidatorsParamsStore
where key isEMPTY_BYTES
Schema
setValidatorsParams
method to validators module, and this method should insert the updated next validators to the contextimpliesMaxPrevotes
as fieldNumber12
and increment other properties latersetValidatorsParams
from validators module instead of callingcontext.setNextValidators
Consensus
type and schema from ABIb.header. aggregateCommit.height
instead ofmaxHeightCertified
in the applicationimpliesMaxPrevotes
usage from the context should be replaced byb.header.impliesMaxPrevotes
Acceptance Criteria
Additional Information
impliesMaxPrevotes
The text was updated successfully, but these errors were encountered: