This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update ABI not to pass the consensus information #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
commented
Oct 20, 2022
shuse2
force-pushed
the
7567-update_validator
branch
2 times, most recently
from
ab2f863
to
9a88c9d
Compare
janhack
reviewed
Oct 24, 2022
shuse2
force-pushed
the
7567-update_validator
branch
from
31c89d8
to
be417ee
Compare
- Update validators module to store consensus information before passing to ABI - Update DPoS module to use validators module instead of replying directly - Update block header to add impliesMaxPrevotes - Update consensus to verify impliesMaxPrevotes - Update generator to add impliesMaxPrevotes
shuse2
force-pushed
the
7567-update_validator
branch
from
be417ee
to
4bc503e
Compare
Incede
suggested changes
Nov 1, 2022
Incede
suggested changes
Nov 2, 2022
- Update getValidatorAccount to getValidatorKeys - Update impliesMaxPrevote to impliesMaxPrevotes - Remove _computeValidatorsHash and use the the same util function - Update setValidatorsParam to handle setting the keys
shuse2
changed the title
Incede
approved these changes
Nov 2, 2022
has5aan
approved these changes
Nov 3, 2022
janhack
reviewed
Nov 4, 2022
ishantiw
pushed a commit
that referenced
this pull request
Nov 15, 2022
This PR resolves #7567 Update engine and application based on LiskArchive/lips#177 - Update validators module to store consensus information before passing to ABI - Move `getSlotTime`, `getSlotNumber` and `getGeneratorAtTimestamp` to BFT method, and update its usages - Update DPoS module to use validators module instead of replying directly through context - Update block header to add impliesMaxPrevote - Update consensus to verify impliesMaxPrevote - Update generator to add impliesMaxPrevote - Add genesis block validation for impliesMaxPrevote - Update dpos module unlock to use aggregateCommit.height for checking certified - Add more test case impliesMaxPrevote method - Update the usage and test for the consensus params Currently genesis timestamp is not stored in BFT module LiskArchive/lips#177 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7567
How was it solved?
Update engine and application based on LiskArchive/lips#177
getSlotTime,getSlotNumberandgetGeneratorAtTimestampto BFT method, and update its usagesHow was it tested?
Additional Information
Currently genesis timestamp is not stored in BFT module LiskArchive/lips#177 (comment)