This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 455
Run mocha tests by npm scripts & Remove Gruntfile.js - Closes #2935 #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f08160
to
44e6399
Compare
shuse2
suggested changes
Mar 14, 2019
fchavant
suggested changes
Mar 15, 2019
d1119d7
to
3f722d3
Compare
fchavant
reviewed
Mar 15, 2019
fchavant
previously approved these changes
Mar 15, 2019
lsilvs
reviewed
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I start functional tests I can't stop them
How to reproduce:
npm run mocha:functional -- --grep "@slow|@unstable" --invert
Try to exit (control + c
) before it finish
@lsilvs That's because functional tests also spawn child processes. Unfortunately, it's not related to lisk mocha runner, we need to update the functional tests accordingly. |
|
shuse2
reviewed
Mar 18, 2019
lsilvs
previously approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
shuse2
approved these changes
Mar 18, 2019
MaciejBaj
approved these changes
Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
After introducing jest to our codebase, we had 2 test runners which had different api to be executed.
How did I fix it?
How to test it?
Please see: https://github.com/LiskHQ/lisk/blob/e06f5c121eef27a13874a48bfc5ca19052d1590e/README.md#running-mocha-tests
Review checklist