Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Functional tests don't stop with SIGINT #3098

Closed
yatki opened this issue Mar 18, 2019 · 1 comment · Fixed by #3284
Closed

Functional tests don't stop with SIGINT #3098

yatki opened this issue Mar 18, 2019 · 1 comment · Fixed by #3284

Comments

@yatki
Copy link
Contributor

yatki commented Mar 18, 2019

Expected behavior

When I terminate the main command, subprocesses should quit gracefully.

Actual behavior

beforeAll hook in framework/test/mocha/functional/functional.js keeps the subprocesses alive.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

1.6.0+

@yatki
Copy link
Contributor Author

yatki commented Apr 8, 2019

Just for reference: https://nodejs.org/api/child_process.html#child_process_subprocess_kill_signal

On Linux, child processes of child processes will not be terminated when attempting to kill their parent. This is likely to happen when running a new process in a shell or with the use of the shell option of ChildProcess:

shuse2 added a commit that referenced this issue Apr 9, 2019
…with-SIGINT

Functional tests don't stop with SIGINT - Closes #3098
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant