Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Rename cryptography function name regarding base32 address - Closes #6283 #6315

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

This PR resolves #6283

How was it solved?

  • Renamed original Base32 address functions to Lisk32 address
  • Linked Base32 address functions originals
  • Marked these Base32 address functions as deprecated
  • Updated tests

How was it tested?

  • Run all tests

@nazarhussain nazarhussain changed the base branch from development to hotfix/5.0.5 April 12, 2021 09:48
@shuse2 shuse2 requested a review from mitsuaki-u April 12, 2021 11:33
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. There are several usage of base32 function in commander, so we can update those as well?

Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@nazarhussain
Copy link
Contributor Author

@shuse2 Tests are updated.

@shuse2 shuse2 merged commit ad6553a into hotfix/5.0.5 Apr 13, 2021
@shuse2 shuse2 deleted the 6283-lisk-address branch April 13, 2021 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename cryptography function name regarding base32 address
3 participants