Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron app does not validate URLs on new windows and navigation #5284

Closed
eniolam1000752 opened this issue Sep 1, 2023 · 0 comments
Closed

Comments

@eniolam1000752
Copy link
Contributor

Actual behavior

Partially resolved in PR #5157. The issue was fixed by limiting new navigations for the localhost and lisk.com hostnames. However, the protocol of the URLis not checked, so URLs such as smb://localhost incorrectly pass this check. We recommend also ensuring that the protocol is https. Furthermore, the catch block of handleRedirect function does not have a call to e.preventDefault(), which may allow other bypasses (we did not attempt to exploit this).

@eniolam1000752 eniolam1000752 added this to the Sprint 107 milestone Sep 1, 2023
@eniolam1000752 eniolam1000752 self-assigned this Sep 1, 2023
@ManuGowda ManuGowda changed the title TOB-LISK-56: Electron app does not validate URLs on new windows and navigation Electron app does not validate URLs on new windows and navigation Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants