Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Electron app does not validate URLs on new windows and navigation #5287

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Sep 1, 2023

What was the problem?

This PR resolves #5284

How was it solved?

  • Added protocol checks on navigating to an external link

How was it tested?

  • Start up the electron app using this command yarn build:electron && yarn start
  • Open up the dev console command + shift + i
  • Execute this snippet on the console location.href = 'https://lisk.com'
  • It would be observed that this link would be opened in default browser
  • Try again by executing this snippet on the console location.href = 'http://lisk.com'
  • it should be observed that this link would not be navigated to.

@eniolam1000752 eniolam1000752 marked this pull request as ready for review September 1, 2023 12:59
@ManuGowda ManuGowda merged commit b3e7945 into release/3.0.0 Sep 4, 2023
3 checks passed
@ManuGowda ManuGowda deleted the 5284-fix-protocol-validation branch September 4, 2023 09:04
@ManuGowda ManuGowda restored the 5284-fix-protocol-validation branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5284-fix-protocol-validation branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants