Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: validate urls on navigation. #5157

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Bug fix: validate urls on navigation. #5157

merged 13 commits into from
Jul 12, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Jul 7, 2023 •
edited
Loading

What was the problem?

This PR resolves #5112

How was it solved?

  • Added allowed domains that can be navigated to

How was it tested?

  • Start up the electron app using this command yarn build:electron && yarn start
  • Open up the dev console command + shift + i
  • Execute this snippet on the console location.href = 'https://lisk.com'
  • It would be observed that this link would be opened in default browser
  • Try again by executing this snippet on the console location.href = 'https://google.com'
  • it should be observed that this link would not be navigated to.

@eniolam1000752 eniolam1000752 self-assigned this Jul 7, 2023
ManuGowda
ManuGowda previously approved these changes Jul 11, 2023
View reviewed changes
oskarleonard
oskarleonard previously approved these changes Jul 11, 2023
View reviewed changes
@ManuGowda ManuGowda merged commit 28e5d0a into release/3.0.0 Jul 12, 2023
@ManuGowda ManuGowda deleted the 5112-validate-navigating-urls branch July 12, 2023 07:26
@eniolam1000752 eniolam1000752 mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarleonard oskarleonard oskarleonard approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @oskarleonard