Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor redux files for bookmarks - Closes #2022 #2140

Merged
merged 7 commits into from Jun 19, 2019
Merged

Refactor redux files for bookmarks - Closes #2022 #2140

merged 7 commits into from Jun 19, 2019

Conversation

massao
Copy link
Contributor

@massao massao commented Jun 14, 2019 •
edited

What issue have I solved?

#2022

How have I implemented/fixed it?

  • Replaced subscriber with middleware;
  • Updated getBookmarksFromLocalStorage to save back to localStorage in case it loaded from followedAccounts key;
  • Refactored to use bookmarks instead of accounts where possible;
  • Updated reducers to be less imperative.

How has this been tested?

Bookmarks should still work as before.

Review checklist

@massao massao added this to the Sprint 2 milestone Jun 14, 2019
@massao massao self-assigned this Jun 14, 2019
@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 14, 2019
@massao massao removed this from the Sprint 2 milestone Jun 14, 2019
@massao massao added this to the Sprint 3 milestone Jun 18, 2019
@massao massao requested a review from osvaldovega June 18, 2019 12:05
@massao massao marked this pull request as ready for review June 18, 2019 12:05
@massao massao requested a review from yasharAyari June 18, 2019 12:05
osvaldovega
osvaldovega approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, is easy to read and understand and better implementation🧹

yasharAyari
yasharAyari approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @massao. 👍

@massao massao merged commit 94644b7 into development Jun 19, 2019
Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 19, 2019
@massao massao deleted the 2022-refactor-redux-files-for-bookmarks branch July 23, 2019 09:11
@slaweet slaweet added the ready label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasharAyari yasharAyari yasharAyari approved these changes

@osvaldovega osvaldovega osvaldovega approved these changes

Assignees

@massao massao

Labels
None yet
Projects
No open projects
Version 1.19.0
  
Merged Pull Requests
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@massao @yasharAyari @osvaldovega @slaweet