Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor redux files for bookmarks - Closes #2022 #2140

Merged
merged 7 commits into from Jun 19, 2019
Merged

Refactor redux files for bookmarks - Closes #2022 #2140

merged 7 commits into from Jun 19, 2019

Commits on Jun 14, 2019

  1. ♻️ Removed subscriber and created middleware

    @massao
    massao committed Jun 14, 2019
    Copy the full SHA
    aab898f View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. ♻️ Make getBookmarksFromLocalStorage save it after normalizing the data

    @massao
    massao committed Jun 17, 2019
    Copy the full SHA
    1c4834d View commit details
    Browse the repository at this point in the history

  2. ♻️ Adjust validation

    @massao
    massao committed Jun 17, 2019
    Copy the full SHA
    5b68dc1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. ♻️ Replace account for bookmark on utils file

    @massao
    massao committed Jun 18, 2019
    Copy the full SHA
    163b930 View commit details
    Browse the repository at this point in the history

  2. ✅ Adjust unit test to use constant instead of hardcoded string

    @massao
    massao committed Jun 18, 2019
    Copy the full SHA
    6dfed43 View commit details
    Browse the repository at this point in the history

  3. ♻️ Make reducer less imperative

    @massao
    massao committed Jun 18, 2019
    Copy the full SHA
    9c80da0 View commit details
    Browse the repository at this point in the history

  4. ✅ Change map for forEach on middlewares/bookmarks.test.js

    @massao
    massao committed Jun 18, 2019
    Copy the full SHA
    5bc24f5 View commit details
    Browse the repository at this point in the history