Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamp calculation and account creation bugs #5268

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Fix timestamp calculation and account creation bugs #5268

merged 8 commits into from
Aug 29, 2023

Conversation

ManuGowda
Copy link
Contributor

@ManuGowda ManuGowda commented Aug 28, 2023 •
edited
Loading

What was the problem?

This PR resolves #5266, #5236

How was it solved?

  • Fix last forger timestamp calculation
  • Fix account creation to not use legacy address derivation
  • Bug fixes related to blockchain application and few other minor UI bugs.

How was it tested?

  • view validators tab and go over some validator profile and check the last forged timestamp
  • Use latest protocol with CDP for account creation
  • CSS and text changes for UI bugs

@ManuGowda ManuGowda self-assigned this Aug 28, 2023
@ManuGowda ManuGowda changed the title 🐛 Fix timestamp calculation Fix timestamp calculation Aug 28, 2023
oskarleonard
oskarleonard previously approved these changes Aug 28, 2023
View reviewed changes
@ManuGowda ManuGowda changed the title Fix timestamp calculation Fix timestamp calculation and account creation bugs Aug 28, 2023
eniolam1000752
eniolam1000752 previously approved these changes Aug 28, 2023
View reviewed changes
ikem-legend
ikem-legend previously approved these changes Aug 29, 2023
View reviewed changes
@ManuGowda ManuGowda merged commit ffc947e into release/3.0.0 Aug 29, 2023
7 checks passed
@ManuGowda ManuGowda deleted the 5266-bugfix-generatio-timestamp branch August 29, 2023 08:23
@ManuGowda ManuGowda restored the 5266-bugfix-generatio-timestamp branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5266-bugfix-generatio-timestamp branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarleonard oskarleonard oskarleonard approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

@eniolam1000752 eniolam1000752 eniolam1000752 approved these changes

Assignees

@ManuGowda ManuGowda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ManuGowda @oskarleonard @ikem-legend @eniolam1000752