Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a user from switching to a custom network which fails #5330

Merged

Conversation

oskarleonard
Copy link
Contributor

What was the problem?

This PR resolves #5309

How was it solved?

Make sure our networkClient is set before making the request. This is to prevent race conditions.

How was it tested?

  1. Switch from Betanet to Testnet
  2. Expected: Show error in the dropdown
  3. Do this a couple of times, switching between Betanet, Testnet and your locally added devnet
  4. Expected: Should not get into a freeze state as in the issue.

@oskarleonard oskarleonard self-assigned this Sep 21, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the issue of residual persisted network/application information lingering around the local storage even though they have been removed.

Below is a list of all the networks which I don't even see in my network list

image image

Copy link
Contributor

@eniolam1000752 eniolam1000752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On editing a previously added custom network, the name on the selected network becomes empty.
image

@ManuGowda ManuGowda removed the request for review from ikem-legend September 22, 2023 15:18
@ManuGowda ManuGowda merged commit d3f0c60 into release/3.0.0 Sep 22, 2023
6 checks passed
@ManuGowda ManuGowda deleted the 5309-switch-to-working-network-from-nonworking branch September 22, 2023 15:18
@ManuGowda ManuGowda restored the 5309-switch-to-working-network-from-nonworking branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5309-switch-to-working-network-from-nonworking branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants