Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event & Action name validation regex definitions are different in Base class #3008

Closed
yatki opened this issue Mar 1, 2019 · 0 comments

Comments

Projects
4 participants
@yatki
Copy link
Member

commented Mar 1, 2019

Expected behavior

Regex validation should be the same throughout the whole framework.

Actual behavior

Event name cannot start with a number as its stated in Event class but isValidEventName method in Base Class has different regex definition.

https://github.com/LiskHQ/lisk/blob/cd67812d1548b3f383707d64274bc9f001517896/framework/src/controller/channels/base.js#L97

https://github.com/LiskHQ/lisk/blob/cd67812d1548b3f383707d64274bc9f001517896/framework/src/controller/event.js#L3

Also isValidActionName method in Base Class has different regex definition than Action class.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

@MaciejBaj MaciejBaj added this to To do in Version 1.6.0 via automation Mar 20, 2019

@MaciejBaj MaciejBaj moved this from To do to In progress in Version 1.6.0 Mar 22, 2019

@MaciejBaj MaciejBaj changed the title Event & Action name validation regex definitions are different in Base class. Event & Action name validation regex definitions are different in Base class Mar 22, 2019

Version 1.6.0 automation moved this from In progress to Done Mar 24, 2019

MaciejBaj added a commit that referenced this issue Mar 24, 2019

Merge pull request #3167 from LiskHQ/3008-module_event_regexp_fix
Event & Action name validation regex definitions are different in Base class - Closes #3008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.