This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Event & Action name validation regex definitions are different in Base class - Closes #3008 #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatki
previously approved these changes
Mar 22, 2019
MaciejBaj
changed the title
|
Fixing tests 😢 |
|
@MaciejBaj seems to be something wrong with retrieving the constants from the node as the tests already timeout before running any of them. |
shuse2
reviewed
Mar 23, 2019
shuse2
approved these changes
Mar 23, 2019
michielmulders
approved these changes
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Event & Action name validation regex definitions are different in Base class.
How did I fix it?
Fixed the
module:eventregexp and reuse the same in base and event.Review checklist