Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent deserialization and serialization - Closes #4131 #4391

Merged
merged 11 commits into from Oct 16, 2019

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented Oct 14, 2019

What was the problem?

There were multiple code that handles seralizing and deserializing, and it was not consistent.
Also, there was no way to serialize and deserialize based on version.

How did I solve it?

  • Add generic deserialization and serialization in blocks module
  • Add pipeline serialize and deserialize to block_processor
  • Use serialize and deserialize pipeline in processor, and expose them for external usage

How to manually test it?

All the syncing, rebuilding, and forging should work as expected

Review checklist

@shuse2 shuse2 requested review from lsilvs and removed request for yatki October 15, 2019 07:15
framework/src/modules/chain/blocks/blocks.js Outdated Show resolved Hide resolved
framework/src/modules/chain/blocks/blocks.js Outdated Show resolved Hide resolved
framework/src/modules/chain/processor/processor.js Outdated Show resolved Hide resolved
framework/src/modules/chain/processor/processor.js Outdated Show resolved Hide resolved
framework/src/modules/chain/processor/processor.js Outdated Show resolved Hide resolved
framework/src/modules/chain/rebuilder.js Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit cab6ba8 into feature/introduce_bft_consensus Oct 16, 2019
@shuse2 shuse2 deleted the 4131-consistent_deserializing branch October 16, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants