New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consistent deserialization and serialization - Closes #4131 #4391
Merged
shuse2
merged 11 commits into
feature/introduce_bft_consensus
from
4131-consistent_deserializing
Oct 16, 2019
Merged
Add consistent deserialization and serialization - Closes #4131 #4391
shuse2
merged 11 commits into
feature/introduce_bft_consensus
from
4131-consistent_deserializing
Oct 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielmulders
suggested changes
Oct 15, 2019
framework/src/modules/chain/synchronizer/block_synchronization_mechanism.js
Show resolved
Hide resolved
2snEM6
suggested changes
Oct 15, 2019
2snEM6
approved these changes
Oct 16, 2019
michielmulders
approved these changes
Oct 16, 2019
ManuGowda
approved these changes
Oct 16, 2019
…LiskHQ/lisk-sdk into 4131-consistent_deserializing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There were multiple code that handles seralizing and deserializing, and it was not consistent.
Also, there was no way to serialize and deserialize based on version.
How did I solve it?
serialize
anddeserialize
to block_processorserialize
anddeserialize
pipeline in processor, and expose them for external usageHow to manually test it?
All the syncing, rebuilding, and forging should work as expected
Review checklist