Add consistent deserialization and serialization - Closes #4131

framework/src/modules/chain/bft/bft.js

@@ -93,6 +93,34 @@ class BFT extends EventEmitter {
 		});
 	}
 
+	/**
+	 * Serialize common properties to the JSON format
+	 * @param {*} blockInstance Instance of the block
+	 * @returns JSON format of the block
+	 */
+	// eslint-disable-next-line class-methods-use-this
+	serialize(blockInstance) {
+		return {
+			...blockInstance,
+			maxHeightPreviouslyForged: blockInstance.maxHeightPreviouslyForged || 0,
+			prevotedConfirmedUptoHeight:
+				blockInstance.prevotedConfirmedUptoHeight || 0,
+		};
+	}
+
+	/**
+	 * Deserialize common properties to instance format
+	 * @param {*} blockJSON JSON format of the block
+	 */
+	// eslint-disable-next-line class-methods-use-this
+	deserialize(blockJSON) {
+		return {
+			...blockJSON,
+			maxHeightPreviouslyForged: blockJSON.maxHeightPreviouslyForged || 0,
+			prevotedConfirmedUptoHeight: blockJSON.prevotedConfirmedUptoHeight || 0,
+		};
+	}
+
 	/**
 	 * When blocks deleted send those to BFT to update BFT state
 	 *

framework/src/modules/chain/block_processor_v0.js

@@ -116,6 +116,12 @@ class BlockProcessorV0 extends BaseBlockProcessor {
 		this.constants = constants;
 		this.exceptions = exceptions;
 
+		this.deserialize.pipe([
+			({ block }) => this.blocksModule.deserialize(block),
+		]);
+
+		this.serialize.pipe([({ block }) => this.blocksModule.serialize(block)]);
+
 		this.validate.pipe([
 			data => this._validateVersion(data),
 			data => validateSchema(data),

framework/src/modules/chain/block_processor_v2.js

@@ -184,6 +184,16 @@ class BlockProcessorV2 extends BaseBlockProcessor {
 
 		this.init.pipe([() => this.bftModule.init()]);
 
+		this.deserialize.pipe([
+			({ block }) => this.blocksModule.deserialize(block),
+			(_, updatedBlock) => this.bftModule.deserialize(updatedBlock),
+		]);
+
+		this.serialize.pipe([
+			({ block }) => this.blocksModule.serialize(block),
+			(_, updatedBlock) => this.bftModule.serialize(updatedBlock),
+		]);
+
 		this.validate.pipe([
 			data => this._validateVersion(data),
 			data => validateSchema(data),