Add http-api for GET api/peers?limit=xxx&offset=yyy&state=zzz endpoint - Closes #5254 #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
5254_http_api_get_peers
branch
2 times, most recently
from
d53d68e
to
6bc1ce3
Compare
shuse2
requested review from
nazarhussain and
mitsuaki-u
and removed request for
shuse2
nazarhussain
suggested changes
Jul 10, 2020
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
mitsuaki-u
suggested changes
Jul 10, 2020
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
ishantiw
commented
Jul 10, 2020
framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
Outdated
Show resolved
Hide resolved
mitsuaki-u
approved these changes
Jul 10, 2020
ishantiw
force-pushed
the
5254_http_api_get_peers
branch
from
edc1bb7
to
593e74b
Compare
nazarhussain
approved these changes
Jul 13, 2020
ishantiw
force-pushed
the
5254_http_api_get_peers
branch
from
593e74b
to
aa1cd6c
Compare
ishantiw
force-pushed
the
5254_http_api_get_peers
branch
from
aa1cd6c
to
51bee53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5254
How was it solved?
api/peersURL and ControllerHow was it tested?
Run
npm run test:functional peers.spec.tsunderframework-plugins/lisk-framework-http-api-plugin/