Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] too long translation ? #115

Closed
EVOTk opened this issue Aug 3, 2021 · 3 comments
Closed

[QUESTION] too long translation ? #115

EVOTk opened this issue Aug 3, 2021 · 3 comments
Assignees
Labels
🤷‍♂️ Question [ISSUE] Further information is requested

Comments

@EVOTk
Copy link
Contributor

EVOTk commented Aug 3, 2021

Hello,

I started a French translation, I have a question about the layout:

For example, in the configuration menu, when the text is too long, this one finds shifted and centered it is not very nice.

2021-08-03 13_07_05-Window

2021-08-03 13_06_56-Window

Do I have to use an abbreviation like for example:
"Infos on the application" instead of "Information on the applications" or should we rather provide a modification of the script so that the boxes adapt to the size of the text?

Thank you

@EVOTk EVOTk added the 🤷‍♂️ Question [ISSUE] Further information is requested label Aug 3, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Aug 4, 2021

Thanks for raising this (and thank you for working on a French translation!).

I will make some modifications to the styles to fix this, so that the text doesn't wrap onto the next line. Am at work at the moment, but will do a PR to fix this this evening :)

You're right, this doesn't look good, I had forgotten to account for other languages being different lengths. Did you notice any other places where something similar happens?

@Lissy93
Copy link
Owner

Lissy93 commented Aug 4, 2021

Fixed in 6f59430 of PR #116 :)

I'm looking forward to Dashy having a French version! 😄🗼 Let me know if you need any help.
If you add your language to the supported language section of the readme, then if you like, then you can also tag yourself if you'd like some credit, e.g.

- 🇫🇷 **French**: `fr` - Translated by [@EVOTk](https://github.com/EVOTk)

@Lissy93 Lissy93 closed this as completed Aug 4, 2021
Lissy93 added a commit that referenced this issue Aug 4, 2021
Fixes #115
[FIX] Text overflows when language is very long
@EVOTk
Copy link
Contributor Author

EVOTk commented Aug 4, 2021

Hello,
Thank you again for your responsiveness!

Did you notice any other places where something similar happens?
No, but I have not yet fully translated.

I am traveling on business this week.
I should be able to make a PR this weekend or sometime next week.

Thanks for the suggestion;)

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Closes Lissy93#115

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷‍♂️ Question [ISSUE] Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants