Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Text overflows when language is very long #116

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 4, 2021

Category: Minor / UI Bugfix

Overview
With some languages (e.g. French) the text is considerably longer. This caused issues with text wrapping onto the next line of the config container's buttons, which didn't look very neat. This PR fixes this, by making the width of the button equal to that of the longest line of text.

Issue Number #115

New Vars N/A

Screenshot
image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 86a04c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/610aec6b86f46500073d1e48

😎 Browse the preview: https://deploy-preview-116--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit ae8c33b into master Aug 4, 2021
@Lissy93 Lissy93 deleted the FIX/ui-support-long-languages branch August 4, 2021 19:52
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#116

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant