Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Multi-Page Support #617

Merged
merged 31 commits into from May 1, 2022
Merged

[FEATURE] Multi-Page Support #617

merged 31 commits into from May 1, 2022

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Apr 27, 2022

✨ Feature Large Lissy93 /FEATURE/multi-page-support-2 → Lissy93/dashy Commits: 31 | Files Changed: 38 | Additions: 628 Unchecked Tasks

Category: Feature

Overview
You've requested it... here is a working implementation of multi-page support!

Will be ready for merge once I've figured out the merge for #606

Issue Number #584 #466

New Vars
pages

Screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit c87e13c
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/626efb4883db480008cf08ce
😎 Deploy Preview https://deploy-preview-617--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@liss-bot liss-bot added the ✨ New Feature [PR] Contains implementation of a new feature label Apr 27, 2022
@viezly
Copy link

viezly bot commented Apr 27, 2022

This pull request is split into 7 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • /
  • docs
  • src
  • src/components
  • src/mixins
  • src/utils

@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request introduces 3 alerts when merging d5c5c4f into 45fa35a - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 3 alerts when merging eb9a5ab into 6018a49 - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 3 alerts when merging 437ec2e into e454f6e - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@Lissy93
Copy link
Owner Author

Lissy93 commented May 1, 2022

Allowing the path to the config file to be modified, could allow for a path traversal attack. Added safeguard in Node server, but still stricter permissions needed.

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 3 alerts when merging c87e13c into e454f6e - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@Lissy93 Lissy93 merged commit 40d1236 into master May 1, 2022
@Lissy93 Lissy93 deleted the FEATURE/multi-page-support-2 branch May 1, 2022 21:50
@liss-bot
Copy link
Collaborator

liss-bot commented May 1, 2022

The fix for this issue has now been released in 2.0.8 ✨

If you haven't done so already, please update your instance to 2.0.8 or later. See 2.0.8 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants