Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme's 720p base makes BG, FG animations and some LUA effects smaller than they should be. #5

Open
MrThatKid opened this issue May 24, 2016 · 4 comments

Comments

@MrThatKid
Copy link

MrThatKid commented May 24, 2016

All pictures taken were with the same verision of Stepmania 5.1 .
As an example, I'll use Mawaru 4 (It was converted to SM5 and just uses FG/BG changes, no crazy LUA involved).
You can get it here.
Demonstrated with Pump gameplay (What style it's played in doesn't matter)
https://www.youtube.com/watch?v=eOfb_Juyk98
What's supposed to happen? Things like the intro 'video' are supposed to at least fill the hight of the screen.
What's it supposed to look like? This.
What actually happens? They are smaller than they should be.
What does actually it look like? This.
Yes, the arrows/screenshots look glitchy. That happens when I take screenshots of moving items in Stepmania. You get the general idea, though.
More examples:
TaroNuke's Louder Louder file. (Uses LUA mods and animations)
Suposed to look like: This.
Actually looks like: This.
Yes, the arrows suffer from being too small as well.
UPSRT pack - Cooler Than Blue. Demonstrated here at 4:10 in the video. (Also uses LUA mods and animations)
Suposed to look like: This.
Actually looks like: This.
Version: StepMania5.1-git-cfa998e
Compiled 20160523 @ 23:11:46 (build cfa998e) on Ubuntu 16.04 64-bit.
Resolution: 1440x810 @ 16:9 ratio.

@MrThatKid MrThatKid changed the title BG, FG animations and some LUA effects are a bit broken (too small than they should be). Theme's 720p base makes BG, FG animations and some LUA effects smaller than they should be. May 24, 2016
@kyzentun
Copy link
Contributor

This turned out exactly as I predicted. It's why I've opposed going from 480 to 720 from the start. I haven't figured out a solution that would work at all.

@ListenerJubatus
Copy link
Owner

We can already scale background images and videos to fit the screen or avoid letterboxing/pillarboxing by the user's request, but this may be tricker.

All and all, this is a StepMania problem and not mutually exclusive to this theme. However, if this isn't fixed, we must (unfortunately) downscale this theme back down to 480. It's a shame that I'd have to face nerfing one of the big selling points of this theme just to maintain backwards compatibility rather than try and fix things upstream.

I've posted about this on the main SM bug tracker. We'll either have to fix this, or downconvert the theme.

@shakesoda
Copy link

Don't scale the theme down because of a stupid bug. Scaling isn't even
difficult.

  • Colby

On Wed, May 25, 2016 at 10:06 AM, ListenerJubatus notifications@github.com
wrote:

We can already scale background images and videos to fit the screen or
avoid letterboxing/pillarboxing by the user's request, but this may be
tricker.

All and all, this is a StepMania problem and not mutually exclusive to
this theme. However, if this isn't fixed, we must (unfortunately) downscale
this theme back down to 480. It's a shame that I'd have to face nerfing one
of the big selling points of this theme just to maintain backwards
compatibility rather than try and fix things upstream.

I've posted about this on the main SM bug tracker
stepmania/stepmania#1133. We'll either have
to fix this, or downconvert the theme.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5 (comment)

@ListenerJubatus
Copy link
Owner

Okay, actually, I think I might have an idea about how we could work around this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants