-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LF-4215 Write migration to add columns to product table and create update APIs #3200
Merged
SayakaOno
merged 12 commits into
integration
from
LF-4215-write-migration-to-add-columns-to-product-table-and-create-update-ap-is
May 1, 2024
Merged
LF-4215 Write migration to add columns to product table and create update APIs #3200
SayakaOno
merged 12 commits into
integration
from
LF-4215-write-migration-to-add-columns-to-product-table-and-create-update-ap-is
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take farm_id from headers and not body; remove generation of the unused translation_key; update error handling
Also add constraints for name uniqueness and positive npk values
Forgot to include this in the down function
SayakaOno
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left one minor comment :)
Also refactor test helper functions for readability and to remove unused
SayakaOno
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
SayakaOno
added a commit
that referenced
this pull request
Jun 24, 2024
…add-columns-to-product-table-and-create-update-ap-is LF-4215 Write migration to add columns to product table and create update APIs
SayakaOno
added a commit
that referenced
this pull request
Jun 25, 2024
…add-columns-to-product-table-and-create-update-ap-is LF-4215 Write migration to add columns to product table and create update APIs
SayakaOno
added a commit
that referenced
this pull request
Jun 25, 2024
…add-columns-to-product-table-and-create-update-ap-is LF-4215 Write migration to add columns to product table and create update APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the backend updates to the
product
table and routesnpk_unit
columns added/product
and adding a new PATCHproject.js
middleware) has been available to all users, the same will now be done for POST and PATCH directly on the product routescheckProductValidity.js
)Jira link: https://lite-farm.atlassian.net/browse/LF-4215
Type of change
How Has This Been Tested?
Checklist: