-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lf 3773 the user is able to edit the already deleted expense #3293
Lf 3773 the user is able to edit the already deleted expense #3293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works really well for me and fixes the error well.
I was actually seeing a different scenario than the Jira ticket -- on integration I see both a success and an error message with he database successfully updating.
The get method in the saga after success snackbar was failing and so after the success message runs I would see the error message too.
My only concern is the length of the message being too long for the duration of the snackbar!
…already-deleted-expense-revenue update with integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
@Duncan-Brain I tried running pnpm i18n
to sort the translation keys alphabetically, but it made a lot of changes (it replaced the space before "?" in fr with \u00a0
, and added SPECIES_COUNT_many
). I will bring this up in the tech daily on Tuesday to hear your suggestions!
Thanks Gursimran! |
Description
When two users are logged on to the same farm and one user begins to edit the expense while another user delete/retire the same expense, the first uses is able to save the expense even if it is deleted. It was expected that the user won’t have a possibility to edit the already deleted expense. In this case an error snackbar message should be displayed.
Jira link:https://lite-farm.atlassian.net/browse/LF-3773
Type of change
How Has This Been Tested?
Login with two different users the onto same farm and try to edit the expense. Meanwhile, if another user delete the same expense, then first user will get an error message explaining the situation on saving the expense.
Checklist: