-
Notifications
You must be signed in to change notification settings - Fork 42
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes, I do not have access to the exchange rate for fiat #29
Comments
Have you seen this happen recently? I may add some more fiat exchange APIs for when the Yahoo! query fails... |
Now, it works perfectly, but yesterday it didn't work for a few hours... On 18/01/2014 04:03, hank - notifications@github.com wrote:
|
OK - it seems like your Yahoo! exchange API request is failing occasionally. It would be good to have a backup for this anyway. I found this: https://blockchain.info/ticker Since this has USD on it, we should be able to parse it into BigDecimal and get the fiat currency scaling factors (which is exactly what I'm doing with the Yahoo! API). It wouldn't take too much code to add this. I'm scheduling it for the next release and leaving it unassigned for now. |
I can try looking into that. But simply reading the readme of the wallet, quote https://github.com/adv0r/bitcoin-wallet/tree/messy/wallet
So its either the readme outdated or the issue is different. There is an inner class into ExchangeRateProvider called YahooRatesProvider . Should I create a BlockchainRateProvider ? Or maybe should look deep into this issue and check against the documentation? |
This wallet is a fork - that readme was written for the original wallet. You have the right idea with the BlockchainRateProvider, but you mentioned there might be some java libs around for doing these API calls so we don't have to do them ourselves - that's worth looking into as well. Also, make it prefer Yahoo since there are more currencies, but fall back to blockchain. Feel free to update the readme as well to reflect the current implementation. Upstream changes can just be ignored for that readme file. |
Is it possible to use the well known BitcoinAverage? Or perhaps : http://www.cryptocoincharts.info/v2/ |
That should work. Maybe we can even make a preference Nogreedy notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
version 3.30.2 (french version) |
This uses a google spreadsheets hack to provide exchange rate data using the Google APIs. It seems work very well. Relevant to #29
This morning (and yesterday afternoon) I hadn't access to exchange rate and then I could'nt choose fiat currency. Only one fiat currency was available (dollar, but I'm not sure exchange rate $/LTC was updated correctly) and I couldn't choose euro (see screencapture below) ...
Since 1 hour, it works : I have access to all foreign currencies and I can choose between €, $, ... (see below)
The text was updated successfully, but these errors were encountered: