Add compiler warning for dangerous use of this (ampproject#5244)

* add checkGlobalThisLevel(warn) to compiler opts * malte's pr comment
Lith · Dec 22, 2016 · 15cefb7 · 15cefb7
1 parent 2080430
commit 15cefb7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/build-system/tasks/compile.js b/build-system/tasks/compile.js
@@ -270,7 +270,11 @@ function compile(entryModuleFilenames, outputDir,
       // it won't do strict type checking if its whitespace only.
       compilerOptions.compilerFlags.define.push('TYPECHECK_ONLY=true');
       compilerOptions.compilerFlags.jscomp_error.push(
-          'checkTypes', 'accessControls', 'const', 'constantProperty');
+          'checkTypes',
+          'accessControls',
+          'const',
+          'constantProperty',
+          'globalThis');
 
       // TODO(aghassemi): Remove when NTI is the default.
       if (argv.nti) {