Fix minVisiblePercentage and maxVisiblePercentage (ampproject#6326)

* Fix minVisiblePercentage and maxVisiblePercentage * Remove 'only'
Lith · Dec 22, 2016 · 9843cac · 9843cac
1 parent f947684
commit 9843cac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/extensions/amp-analytics/0.1/test/test-visibility-impl.js b/extensions/amp-analytics/0.1/test/test-visibility-impl.js
@@ -165,7 +165,9 @@ describe('amp-analytics.visibility', () => {
       elementY: '23', // 13 + 10
       elementWidth: '100',
       elementHeight: '100',
-      loadTimeVisibility: '49', // (100 - 51) * (100 - 0) / 100
+      loadTimeVisibility: '49', // (100 - 51) * (100 - 0) / 100,
+      minVisiblePercentage: '63',
+      maxVisiblePercentage: '63',
       totalTime: sinon.match(value => {
         return isFiniteNumber(Number(value));
       }),

diff --git a/extensions/amp-analytics/0.1/visibility-impl.js b/extensions/amp-analytics/0.1/visibility-impl.js
@@ -495,8 +495,10 @@ export class Visibility {
         ? s[CONTINUOUS_TIME] + sinceLast : 0;
     s[MAX_CONTINUOUS_TIME] = s[MAX_CONTINUOUS_TIME] !== undefined
         ? Math.max(s[MAX_CONTINUOUS_TIME], s[CONTINUOUS_TIME]) : 0;
-    s[MIN_VISIBLE] = s[MIN_VISIBLE] ? Math.min(s[MIN_VISIBLE], visible) : 101;
-    s[MAX_VISIBLE] = s[MAX_VISIBLE] ? Math.max(s[MAX_VISIBLE], visible) : -1;
+    s[MIN_VISIBLE] =
+        s[MIN_VISIBLE] ? Math.min(s[MIN_VISIBLE], visible) : visible;
+    s[MAX_VISIBLE] =
+        s[MAX_VISIBLE] ? Math.max(s[MAX_VISIBLE], visible) : visible;
     s[LAST_VISIBLE_TIME] = Date.now() - s[TIME_LOADED];
   }