fix typos in documentation and call renderStart (ampproject#5644)

* call render-start when ad unit starts to load and fix typos in documentation * minor documentation changes
Lith · Dec 22, 2016 · cb0928d · cb0928d
1 parent 9c903b1
commit cb0928d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/ads/_config.js b/ads/_config.js
@@ -54,6 +54,7 @@ export const adConfig = {
       'https://staticd.cdn.adblade.com',
       'https://static.adblade.com',
     ],
+    renderStartImplemented: true,
   },
 
   adform: {},
@@ -214,6 +215,7 @@ export const adConfig = {
       'https://staticd.cdn.industrybrains.com',
       'https://static.industrybrains.com',
     ],
+    renderStartImplemented: true,
   },
 
   inmobi: {

diff --git a/ads/adblade.js b/ads/adblade.js
@@ -34,6 +34,11 @@ function addAdiantUnit(hostname, global, data) {
   ins.setAttribute('data-tag-type', 1);
   global.document.getElementById('c').appendChild(ins);
 
+  ins.parentNode.addEventListener(
+    'eventAdbladeRenderStart',
+    global.context.renderStart()
+  );
+
   // run our JavaScript code to display the ad unit
   writeScript(global, 'https://' + hostname + '/js/ads/async/show.js');
 }

diff --git a/ads/adblade.md b/ads/adblade.md
@@ -21,8 +21,8 @@ limitations under the License.
 ```html
 <amp-ad width=300 height=250
     type="adblade"
-    width="300"
-    height="250"
+    data-width="300"
+    data-height="250"
     data-cid="19626-3798936394">
 </amp-ad>
 ```
@@ -34,5 +34,5 @@ For semantics of configuration, please see [ad network documentation](https://ww
 Supported parameters:
 
 - data-cid
-- width
-- height
+- data-width
+- data-height
diff --git a/ads/industrybrains.md b/ads/industrybrains.md
@@ -21,8 +21,8 @@ limitations under the License.
 ```html
 <amp-ad width=300 height=250
     type="industrybrains"
-    width="300"
-    height="250"
+    data-width="300"
+    data-height="250"
     data-cid="19626-3798936394">
 </amp-ad>
 ```
@@ -34,5 +34,5 @@ For semantics of configuration, please see [ad network documentation](https://ww
 Supported parameters:
 
 - data-cid
-- width
-- height
+- data-width
+- data-height