Rewrite asset detection + add many more assets to our detection. #462
Conversation
This adds all missing assets from toolkit (thanks Aidan!) We also now store the serialization method (binary, compressed texture, text, etc), and the "Asset Safety Level" differently. Asset Safety Level has been replaced with a new AssetFlags flags enum, which stores whether a specific asset is "Dangerous", "Media", and/or "Modded". This allows us to much more gradually block assets, e.g. block only Media assets, but allow other types of Modded assets, which was not possible before.
Refresh.GameServer/Endpoints/ApiV3/DataTypes/Response/ApiInstanceResponse.cs
Outdated
Show resolved
Hide resolved
|
Conflicting with master. Also, are there any unit tests that should be added to help with this/asset detection in general? We have a few asset tests already but I'm wondering if we can do more. |
# Conflicts: # Refresh.GameServer/Configuration/GameServerConfig.cs # Refresh.GameServer/Database/GameDatabaseProvider.cs # Refresh.GameServer/Endpoints/ApiV3/InstanceApiEndpoints.cs
ideally we have a set of test assets stored in tree which test our dependency tree reading, asset type, serialization method, etc |
Co-authored-by: jvyden <jvyden@jvyden.xyz> Signed-off-by: Beyley Thomas <ep1cm1n10n123@gmail.com>
Co-authored-by: jvyden <jvyden@jvyden.xyz> Signed-off-by: Beyley Thomas <ep1cm1n10n123@gmail.com>
|
No tests yet, but i resolved all the previous review comments |
Refresh.GameServer/Endpoints/ApiV3/DataTypes/Response/ApiInstanceResponse.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jvyden <jvyden@jvyden.xyz> Signed-off-by: Beyley Thomas <ep1cm1n10n123@gmail.com>
|
still needs asset tests, but rebased to latest master and ready for more review |
|
Looks fine but I probably won't review again until we have good tests for this. |
Co-authored-by: jvyden <jvyden@jvyden.xyz> Signed-off-by: Beyley Thomas <ep1cm1n10n123@gmail.com>
|
This is bitrotting to hell and back so I'm just going to re-review, test it manually by re-importing all the assets locally and merge as-is if successful. |
|
Migration seems to be okay |
This adds all missing assets from toolkit (thanks Aidan!)
We also now store the serialization method (binary, compressed texture, text, etc), and the "Asset Safety Level" differently.
Asset Safety Level has been replaced with a new AssetFlags flags enum, which stores whether a specific asset is "Dangerous", "Media", and/or "Modded".
This allows us to much more gradually block assets, e.g. block only Media assets, but allow other types of Modded assets, which was not possible before.
Opening as draft as i have yet to have the time to fully test this ingame, but tests pass locally
May fix #438 aswell, but that needs to be tested