Skip to content

Commit

Permalink
Minor comment/todo clean up.
Browse files Browse the repository at this point in the history
  • Loading branch information
jayjwylie committed Mar 20, 2013
1 parent 83b87bc commit 37d3b76
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/java/voldemort/utils/ConsistencyFix.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@

public class ConsistencyFix {

// TODO: Move ConsistencyFixContext into its own file?
// TODO: Move ConsistencyFixContext into its own file? Or break this apart.
// I.e., explicitly pass adminClient and storeInstance around?
private static class ConsistencyFixContext {

private final AdminClient adminClient;
Expand Down Expand Up @@ -410,12 +411,6 @@ private static List<NodeValue<ByteArray, byte[]>> resolveReadConflicts(boolean v
toReadRepair.add(new NodeValue<ByteArray, byte[]>(v.getNodeId(), v.getKey(), versioned));
}

// TODO: As we discussed, I don't know the read repair code path very
// well. So, feel free to discard my comments if I am off target w.r.t
// to simply doing a get() to fix everything. Semantically, it then
// gives me more comfort that given enough activity to out of sync keys,
// they will eventually reconcile. Our consistency check and fix is then
// simply a way to generate activity to the right keys. -- VChandar
if(verbose) {
System.out.println("Repair work to be done:");
for(NodeValue<ByteArray, byte[]> nodeKeyValue: toReadRepair) {
Expand Down

0 comments on commit 37d3b76

Please sign in to comment.