Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Fixed bug fill and stroke of RowPointView in StackedRowSeries.cs #848

Merged
merged 2 commits into from
Sep 6, 2018

Conversation

jsirsch
Copy link
Contributor

@jsirsch jsirsch commented Aug 27, 2018

Summary

Fixes bug #847.
Fill and Stroke are now displayed in StackedRowSeries.

Solves

Fixes bug #847.

Further Information

I just copied the missing code from RowSeries.cs into StackedRowSeries.cs. I set up a test project, which worked. I used the Example PointState (https://github.com/Live-Charts/Live-Charts/tree/master/Examples/Wpf/CartesianChart/PointState) and changed RowSeries to StackedRowSeries in the xaml-File. It worked as expected.

@jsirsch
Copy link
Contributor Author

jsirsch commented Aug 27, 2018

Please review: @ghyom @obiben @beto-rodriguez

@jsirsch jsirsch changed the title fixed bug fill and stroke of RowPointView in StackedRowSeries.cs Fixed bug fill and stroke of RowPointView in StackedRowSeries.cs Aug 27, 2018
Copy link
Contributor

@obiben obiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me but I don't think I have write access here!

@jsirsch
Copy link
Contributor Author

jsirsch commented Sep 5, 2018

Summary

Fixes bug #855.
Fill and Stroke are now displayed in PieSeries.

Solves

Fixes bug #855.

@jsirsch
Copy link
Contributor Author

jsirsch commented Sep 5, 2018

Please review: @ghyom @beto-rodriguez

@beto-rodriguez beto-rodriguez merged commit 6723ec0 into Live-Charts:master Sep 6, 2018
@jsirsch
Copy link
Contributor Author

jsirsch commented Sep 10, 2018

Many thanks!

@DamianSuess
Copy link

Are there any plans to update the NuGet package?

@beto-rodriguez
Copy link
Collaborator

@DamianSuess yes soon we will have a much solid solution https://github.com/beto-rodriguez/LiveCharts2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants