Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Swift 5, FontAwesome 5.8.1 #43

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Update to Swift 5, FontAwesome 5.8.1 #43

merged 2 commits into from
Apr 2, 2019

Conversation

ghowen
Copy link
Collaborator

@ghowen ghowen commented Apr 2, 2019

  • Conversion to Swift 5
  • Removes warnings in Xcode 10.2 / Swift 5
  • Temporary fix for broken generator due to incompatibility in Alamofire
  • Update to FontAwesome 5.8.1

Georg added 2 commits April 2, 2019 10:23
- Update for Swift 5
aed90e2 
- Removed warnings "'public' modifier is redundant for x declared in a public extension"
- Temp fix for broken Generator due to incompatible package of Alamofire
Raise Swift version to 5 and lib version to 2.2.0
8c31c20
@ghowen ghowen mentioned this pull request Apr 2, 2019
Closed
rafiki270
rafiki270 approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@rafiki270 rafiki270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rafiki270 rafiki270 merged commit 6eb3b6d into LiveUI:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiki270 rafiki270 rafiki270 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghowen @rafiki270