Update Awesome/AwesomePro, make enums CaseIterable and add withKey fu… #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to point out this is an auto-generated file that you're modifying. So any changes you're making to the file will fail the next time they auto generate the file |
|
You are definetly right, didn't update the generator logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CaseIterable to enums allows us to call them dynamicly with rawValue
Awesome.Regular(rawValue: "\u{f007}")?.imageAwesomePro.Regular(rawValue: "\u{f640}")?.imageAdditionally by adding the static withKey function to the enums, we can call icons by the key value as a string
Awesome.Regular.withKey("user")?.imageAwesomePro.Regular.withKey("bell")?.image