Fix/tiling layout precision #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
fix/tiling-layout-precision
branch
10 times, most recently
from
815367a
to
291306a
Compare
merryman
force-pushed
the
fix/tiling-layout-precision
branch
2 times, most recently
from
2350264
to
31719ee
Compare
merryman
force-pushed
the
fix/tiling-layout-precision
branch
3 times, most recently
from
0da5a43
to
68501be
Compare
linusha
reviewed
Jul 2, 2024
linusha
reviewed
Jul 2, 2024
linusha
reviewed
Jul 2, 2024
linusha
force-pushed
the
fix/tiling-layout-precision
branch
from
68501be
to
a85a358
Compare
Previously we would just compute a single offset value, which was not precise enough since it did not differentiate between the different dimensions.
Previously browsers would add invisible scroll space that could not be scrolled to due to margins rendered to the last submorph inside an axis.
For not entirely clear reasons, yoga nodes need to be reset more often than expected. Not only do we need to reset yoga in case submorphs are removed from the world, but also we need to sometimes reset them, when the layout axis changes. Else the yoga layout will return inconclusive results.
Previously we assumed object identity preserved by the .getChild() function which turned out not to be the case.
linusha
force-pushed
the
fix/tiling-layout-precision
branch
from
a85a358
to
bf3af64
Compare
linusha
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1545 and other bugs inside the tiling layout that were not yet reported: