Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web ui): add response headers #1190

Merged
merged 1 commit into from Apr 18, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 16, 2023

Description

Add "Content-Type" response headers to web ui pages which prevented some browsers from rendering Sunshine pages correctly in some cases, such as if a user was running Sunshine behind a proxy.

Screenshot

Issues Fixed or Closed

Fixes #1186

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Apr 16, 2023

Qodana success
Results:
- js
- python

@ReenigneArcher ReenigneArcher force-pushed the fix(web-ui)-add-response-headers branch from b545fa4 to 01146e6 Compare April 18, 2023 14:06
Add "Content-Type" response headers to web ui pages which prevented some browsers from rendering Sunshine pages correctly in some cases, such as if a user was running Sunshine behind a proxy.

Fixes #1186
@ReenigneArcher ReenigneArcher force-pushed the fix(web-ui)-add-response-headers branch from 01146e6 to e3b648f Compare April 18, 2023 21:16
@ReenigneArcher ReenigneArcher merged commit 2215ab9 into nightly Apr 18, 2023
40 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(web-ui)-add-response-headers branch April 18, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants