Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): build with ninja #1218

Closed
wants to merge 1 commit into from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 25, 2023

Description

Build Sunshine with ninja. Apparently this can significantly improve build times.

Build Times

Package ninja make
AppImage 1:48 2:14
Flatpak 28:58
Archlinux 9:52
Debian Bullseye 7:11 6:49
Fedora 36 8:54 9:02
Fedora 37 11:43 11:28
Ubuntu 20.04 8:48 13:36
Ubuntu 22.04 9:23 10:20
MacOS 1:57 2:05
Macports 8:08
Windows 2:27 2:56

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher changed the title build(camke): build with ninja build(cmake): build with ninja Apr 25, 2023
@LizardByte-bot
Copy link
Member

LizardByte-bot commented Apr 25, 2023

Qodana success
Results:
- js
- python

@ReenigneArcher ReenigneArcher force-pushed the build(cmake)-build-with-ninja branch 6 times, most recently from 0c66641 to 1d6f28e Compare April 27, 2023 17:27
@ReenigneArcher ReenigneArcher deleted the build(cmake)-build-with-ninja branch May 7, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants