Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio)!: remove policy config for Windows Vista #1235

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

This PR removes the policy config for Windows Vista audio. Additionally, I have added #include <mmdeviceapi.h> which removes many false positive errors in CLion.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Apr 28, 2023

Qodana success
Results:
- js
- python

@ReenigneArcher ReenigneArcher marked this pull request as ready for review April 28, 2023 15:07
@ReenigneArcher ReenigneArcher force-pushed the fix(audio)!-remove-policy-config-for-Windows-Vista branch from c28c3d5 to 08b2cbb Compare May 1, 2023 00:19
@ReenigneArcher ReenigneArcher merged commit 3cfb520 into nightly May 1, 2023
40 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(audio)!-remove-policy-config-for-Windows-Vista branch May 1, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants