Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement controller arrival metadata support #1402

Merged
merged 1 commit into from Jul 1, 2023

Conversation

cgutman
Copy link
Contributor

@cgutman cgutman commented Jun 28, 2023

Description

This is another PR split out of #1396 that implements the new controller arrival packet protocol extension. This allows the host to match the type of controller provided by the client, which means that prompts in games will have the correct PlayStation or Xbox button symbols. It's also important for vendor-specific extended features like controller touchpad and gyro/accel input.

I marked this as a breaking change because it's changing default behavior to match the client controller type instead of always using an Xbox 360 controller. I think this is desirable and it can be changed back to the old behavior by users if they want.

Screenshot

image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman merged commit 11aedf5 into LizardByte:nightly Jul 1, 2023
40 checks passed
@cgutman cgutman mentioned this pull request Jul 31, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant