Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): use submodule for nvapi opensource #1458

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jul 19, 2023

Description

Use submodule for nvapi-opensource. This will also bump NVAPI from R530 to R535.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Jul 19, 2023

Qodana success
Results:
- python
- js

@ReenigneArcher ReenigneArcher marked this pull request as draft July 20, 2023 01:13
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Jul 20, 2023

TODO in https://github.com/LizardByte/nvapi-open-source-sdk:

@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 20, 2023 13:48
@ReenigneArcher ReenigneArcher force-pushed the build(deps)-use-submodule-for-nvapi-opensource branch from 3f7a38d to 630699e Compare July 20, 2023 15:44
Copy link
Contributor

@ns6089 ns6089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. I wouldn't call it "sdk" since the proper sdk contains docs and samples, while the submodule in question has only compatibility headers. But this is just minor nitpicking.

@ReenigneArcher ReenigneArcher merged commit 4b986b2 into nightly Jul 21, 2023
43 checks passed
@ReenigneArcher ReenigneArcher deleted the build(deps)-use-submodule-for-nvapi-opensource branch July 21, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants