ci: update qodana #1634
Closed
ci: update qodana #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
force-pushed
the
ci-update-qodana
branch
from
b86b80b
to
6258d1f
Compare
|
Todo:
|
ReenigneArcher
force-pushed
the
ci-update-qodana
branch
from
6258d1f
to
3f67e02
Compare
ReenigneArcher
force-pushed
the
ci-update-qodana
branch
from
3f67e02
to
3220e9d
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ReenigneArcher
commented
Sep 18, 2023
| @@ -145,7 +145,7 @@ jobs: | |||
| ref: ${{ github.base_ref || github.ref_name }} # base ref for PR and branch name for push | |||
| workflow: dispatcher.yml | |||
| inputs: ${{ steps.inputs.outputs.primary_inputs }} | |||
| token: ${{ github.token }} | |||
| # token: ${{ github.token }} # when specifying token, fork PRs will not have the right permission | |||
There was a problem hiding this comment.
Suggested change
| # token: ${{ github.token }} # when specifying token, fork PRs will not have the right permission | |
| token: ${{ github.token }} |
revert, didn't work
Comment on lines
-292
to
+299
| token: ${{ github.token }} | ||
| # token: ${{ github.token }} # when specifying token, fork PRs will not have the right permission |
There was a problem hiding this comment.
Suggested change
| token: ${{ github.token }} | |
| # token: ${{ github.token }} # when specifying token, fork PRs will not have the right permission | |
| token: ${{ github.token }} |
revert, didn't work
| artifact-name: qodana-${{ matrix.language }} # yamllint disable-line rule:line-length | ||
| args: '--print-problems,${{ steps.baseline.outputs.baseline_args }}' | ||
| post-pr-comment: false |
There was a problem hiding this comment.
Todo:
- investigate if setting this true works for fork PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update qodana workflow
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.