Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify asset building and use find_program to find NPM #2522

Merged
merged 2 commits into from
May 12, 2024
Merged

Unify asset building and use find_program to find NPM #2522

merged 2 commits into from
May 12, 2024

Commits on May 12, 2024

  1. build: Unify asset building by leveraging CMake's env command 

    `add_custom_target` can also accept multiple commands to be run in
sequence. It isn't clear how quoting applies here, but I've tested it,
and it seems to be behave as expected when spaces are present.
    @chewi @ReenigneArcher
    chewi authored and ReenigneArcher committed May 12, 2024
    Configuration menu
    Copy the full SHA
    c475d53 View commit details
    Browse the repository at this point in the history

  2. build: Use find_program to find NPM so it can be overridden 

    This is useful for Gentoo, which needs to be able to do entirely offline
builds, because it can override this with `true` while shipping
pre-compiled assets. Gentoo has tried to ship cached NPM modules
instead, but it turns out these are very sensitive to the NPM version.
    @chewi @ReenigneArcher
    chewi authored and ReenigneArcher committed May 12, 2024
    Configuration menu
    Copy the full SHA
    4c44738 View commit details
    Browse the repository at this point in the history