Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin-rebuild: add -H to sudo for $systemConfig/activate #783

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Sep 25, 2023

#509 (comment)
It might be nice to add -H to the sudo "$systemConfig/activate" line as well. A quick skim of the activate script doesn't show any references to $HOME but it's still probably a good idea for consistency, especially as someone could write a custom activation script that references this variable or invokes a command that itself consults this variable, and system activation should probably try to avoid any dependency on the initiating user.

Running nix store diff-closure in a activation script displays:

warning: $HOME ... is not owned by you, falling back to the one defined in the 'passwd' file.

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enzime Enzime merged commit 792c2e0 into LnL7:master Sep 30, 2023
6 checks passed
@zowoq zowoq deleted the activate-sudo branch October 1, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants