Add -H to sudo nix-env [...] calls in darwin-rebuild.sh to deal with warning

[malob]

After NixOS/nix#6676, the following warning is displayed when running darwin-rebuild switch:

warning: $HOME ('/Users/jamie') is not owned by you, falling back to the one defined in the 'passwd' file.

This happens because, on macOS sudo does not set $HOME by default, the -H flag needs to be added for it to do so.

Fixes: #481
Fixes: #477

[malob]

@lilyball, seems to know more about this than I do, so tagging her here in case she has context etc. to add.

[lilyball]

It might be nice to add -H to the sudo "$systemConfig/activate" line as well. A quick skim of the activate script doesn't show any references to $HOME but it's still probably a good idea for consistency, especially as someone could write a custom activation script that references this variable or invokes a command that itself consults this variable, and system activation should probably try to avoid any dependency on the initiating user.

[lilyball]

@malob BTW I absolutely love all the recent improvements you've been making here!

[malob]

It might be nice to add -H to the sudo "$systemConfig/activate" line as well. A quick skim of the activate script doesn't show any references to $HOME but it's still probably a good idea for consistency, especially as someone could write a custom activation script that references this variable or invokes a command that itself consults this variable, and system activation should probably try to avoid any dependency on the initiating user.

@lilyball, I don't feel knowledgeable enough about this at the moment to propose this change myself, but if you do, I think you should totally create a PR to propose the change.

[zowoq]

It might be nice to add -H to the sudo "$systemConfig/activate" line as well.

Opened a PR for this: #783