Use Almond.js for minified build #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't see an app cache event within a second, just proceed with what we've got.
We only need to download one js file, and we save a little bandwidth.
Matches our almond.js and r.js versions
|
Looks good. I think the hide/show problem is a different issue and doesn't block this release. |
hampelm
added a commit
that referenced
this pull request
Jul 2, 2013
Use Almond.js for minified build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Almond.js to package the javascript code into a single file. This helps load time a bit and also helps avoid module-loading timeouts on slow connections.
Temporarily work around an Android 2.3 Browser issue where we don't see the application cache events.
/cc @hampelm