Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline search and highlight feature for all dropdown lists #182

Merged

Conversation

Fish013
Copy link
Contributor

@Fish013 Fish013 commented Feb 16, 2020

This is an improvement over the original pull request which changes the search from popup to inline style.
It further contains minor refactoring and documentation additions, aswell as fixes to some odd or jarring behavior while filtering.

@NickRyder
Copy link
Contributor

Could you add in a bunch of pictures illustrating the feature set?

@Fish013
Copy link
Contributor Author

Fish013 commented Feb 16, 2020

Inline Dropdown Search

Showcase

features

General behaviour

  • Accessible by typing when the dropdown is opened
  • The currently selected item text is getting replaced temporarily with the search term
  • Filtering out items that do not match the search term
  • Highlighting the places where matches in items are found with a thin yellow underline
  • Dropdown is resized according to the current number of visible items

Search syntax

  • Search term words separated by a space must all match the entry in given order to be shown
Ordered match

ordered_search_match

Ordered mismatch

ordered_search_nomatch

  • Search does case-insensitive matching and correctly handles special chars
Case-insensitive matching with special chars

case_insensitive_special_char_save

Miscellaneous

  • Search term is reset when dropdown is closed or ESC is pressed
  • Backspace allows you to reword the search term
  • When scrolled and the currently selected item is filtered out, the first currently visible item is selected
  • Minimum dropdown size is 1 item. If nothing matches "<No match>" is shown in this slot.
  • Maximum dropdown size has been reduced from 30 to 20 (this is a buff) to make resizing while filtering feel better

@LocalIdentity LocalIdentity added this to Pending review in 1.4.157.5 Update Feb 17, 2020
@LocalIdentity LocalIdentity merged commit 5c91523 into PathOfBuildingCommunity:dev Feb 25, 2020
1.4.157.5 Update automation moved this from Pending review to Done Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants