-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline search and highlight feature for all dropdown lists #182
Merged
LocalIdentity
merged 14 commits into
PathOfBuildingCommunity:dev
from
Fish013:feature/dropdown-search
Feb 25, 2020
Merged
Inline search and highlight feature for all dropdown lists #182
LocalIdentity
merged 14 commits into
PathOfBuildingCommunity:dev
from
Fish013:feature/dropdown-search
Feb 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes PathOfBuildingCommunity#130 (cherry picked from commit 66ca0ee)
(cherry picked from commit 02634ac)
Could you add in a bunch of pictures illustrating the feature set? |
Inline Dropdown SearchShowcaseGeneral behaviour
Search syntax
Ordered matchOrdered mismatch
Case-insensitive matching with special charsMiscellaneous
|
This reverts commit ba7b607
NickRyder
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement over the original pull request which changes the search from popup to inline style.
It further contains minor refactoring and documentation additions, aswell as fixes to some odd or jarring behavior while filtering.