Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search box to Add Modifier in ItemTab #2163

Closed
wants to merge 6 commits into from

Conversation

pHiney
Copy link
Contributor

@pHiney pHiney commented Feb 10, 2021

The list of crafts is becoming more difficult to find things.

I have tested using Life, life, mana, Wizard.

All lists appear to contain the correct entries and no entries when that is appropriate (eg, Wizard in master crafts)

P

@LocalIdentity
Copy link
Contributor

All the dropdown lists in PoB are already searchable if you just click on them and start typing, that negates the need for this PR

@LocalIdentity
Copy link
Contributor

#182

@pHiney
Copy link
Contributor Author

pHiney commented Feb 10, 2021

All the dropdown lists in PoB are already searchable if you just click on them and start typing, that negates the need for this PR

I had no idea you could do that, and neither do my friends
Probably needs a hint added then ...

@LocalIdentity
Copy link
Contributor

All the dropdown lists in PoB are already searchable if you just click on them and start typing, that negates the need for this PR

I had no idea you could do that, and neither do my friends
Probably needs a hint added then ...

Yeah it could definitely use a hint somewhere I think. If you make a PR for that, I would be happy to merge it

@pHiney pHiney closed this Feb 10, 2021
@pHiney
Copy link
Contributor Author

pHiney commented Feb 10, 2021

.

@pHiney pHiney deleted the SearchAddModifier branch August 30, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants