Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard so seller_order_updated and other mailer won't send to empty recipients list #3348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbarreca
Copy link
Contributor

@rbarreca rbarreca commented Jul 27, 2018

Intended to fix #3347 which was old bug that got elevated by mailer cleanup.

Tasks

  • Filter out unconfirmed users in more mailers
  • Further refactor recipient_list
  • Add and refactor more specs
  • Add more guards to not send empty emails
  • Add specs testing new guards

…y recipients list.

- Filter out unconfirmed users in more mailers
- Add and refactor more specs
@rbarreca rbarreca self-assigned this Jul 27, 2018
@rbarreca rbarreca added the WIP label Jul 27, 2018
@rbarreca rbarreca assigned ivar and unassigned rbarreca Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrderMailer#seller_order_updated delayed jobs are being created without an email to send to
2 participants