Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderMailer#seller_order_updated delayed jobs are being created without an email to send to #3347

Closed
rbarreca opened this issue Jul 27, 2018 · 2 comments · May be fixed by #3348
Closed

OrderMailer#seller_order_updated delayed jobs are being created without an email to send to #3347

rbarreca opened this issue Jul 27, 2018 · 2 comments · May be fixed by #3348
Assignees
@ivar
Projects
Project Board

Comments

@rbarreca
Copy link
Contributor

rbarreca commented Jul 27, 2018 •
edited
Loading

Rollbar is showing https://rollbar.com/LocalOrbit/Local-Orbit/items/507/
@rbarreca rbarreca self-assigned this Jul 27, 2018
@rbarreca rbarreca added this to To do in Project Board via automation Jul 27, 2018
@rbarreca rbarreca moved this from To do to Needs review in Project Board Jul 27, 2018
@rbarreca rbarreca mentioned this issue Jul 27, 2018
Open
5 tasks
@rbarreca rbarreca moved this from Needs review to In progress in Project Board Jul 31, 2018
@rbarreca rbarreca moved this from In progress to To do in Project Board Aug 15, 2018
@rbarreca rbarreca assigned ivar and unassigned rbarreca Aug 15, 2018
@ivar ivar mentioned this issue Aug 28, 2018
Closed
@ivar ivar moved this from To do to Needs review in Project Board Aug 28, 2018
@ivar
Copy link
Contributor

ivar commented Aug 28, 2018

This fix is addressed in PR #3361

@ivar ivar mentioned this issue Aug 28, 2018
Merged
rbarreca added a commit that referenced this issue Sep 20, 2018
@rbarreca
Merge pull request #3455 from LocalOrbit/3347-no_send_to_empty_list
88bce1e 
#3347 no send empty list
@rbarreca rbarreca moved this from Needs review to Awaiting QA in Project Board Sep 20, 2018
@rbarreca rbarreca moved this from Awaiting QA to QA Accepted in Project Board Oct 15, 2018
@rbarreca
Copy link
Contributor Author

Tested on staging by removing users from one supplier org then adding that supplier's items to an existing order and saw no emails went out on Mailtrap.io.

Regression tested by adding items from an org with users and saw order update emails in Mailtrap.

@rbarreca rbarreca added this to the v5.0.12 milestone Oct 15, 2018
@rbarreca rbarreca moved this from QA Accepted to Released in Project Board Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivar ivar

Labels
None yet
Projects
Project Board
  
Released
Milestone
No milestone
2 participants
@ivar @rbarreca