3298 no send update if no change #3361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivar
force-pushed
the
3298-no_send_update_if_no_change
branch
from
b80435e
to
56bb7d1
Compare
ivar
force-pushed
the
3298-no_send_update_if_no_change
branch
from
d751f1e
to
d195149
Compare
ivar
force-pushed
the
3298-no_send_update_if_no_change
branch
from
8acdeff
to
a32b1a7
Compare
ivar
commented
Aug 28, 2018
| mail( | ||
| to: to_list, | ||
| subject: "New Invoice" | ||
| subject: 'Thank you for your order' |
There was a problem hiding this comment.
This change is a bit misleading, I moved some of the methods around and with the changes/simplification of the class, the diff algorithm isn't making it clear that this is actually a different method.
ivar
force-pushed
the
3298-no_send_update_if_no_change
branch
from
5199b37
to
1be71bb
Compare
ivar
commented
Aug 28, 2018
| @@ -2,48 +2,8 @@ class SendUpdateEmails | |||
| include Interactor | |||
|
|
|||
| def perform | |||
| #return if Rails.env.production? | |||
There was a problem hiding this comment.
add require_in_context
ivar
commented
Aug 28, 2018
| @@ -118,6 +113,7 @@ | |||
| end | |||
|
|
|||
| describe ".orders_for_buyer" do | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3347 plus lots of cleanups.
seller_order_update_no_recipient_3347branchThe following specs have been reviewed and run green
spec/interactors/send_update_emails_spec.rbspec/mailers/order_mailer_spec.rbspec/models/order_spec.rbThat said, I couldn't reproduce the issue (#3298) via tests locally so there is still a possibility that the root cause is still outstanding.